Messages in this thread | | | Subject | Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug | From | Sergei Shtylyov <> | Date | Thu, 2 Feb 2017 12:49:59 +0300 |
| |
On 2/2/2017 1:39 AM, Jon Mason wrote:
> From: Hari Vyas <hariv@broadcom.com> > > ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to > bgmac_set_mac_address() but code assumed u8 *. This caused two bytes > chopping and the wrong mac address was configured. > > Signed-off-by: Hari Vyas <hariv@broadcom.com> > Signed-off-by: Jon Mason <jon.mason@broadcom.com> > Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address") > --- > drivers/net/ethernet/broadcom/bgmac.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c > index 0e066dc6..ea24072 100644 > --- a/drivers/net/ethernet/broadcom/bgmac.c > +++ b/drivers/net/ethernet/broadcom/bgmac.c > @@ -1222,11 +1222,15 @@ static int bgmac_set_mac_address(struct net_device *net_dev, void *addr) > { > struct bgmac *bgmac = netdev_priv(net_dev); > int ret; > + struct sockaddr *sa = addr;
DaveM prefers the declarations to be arranged from longest to shortest.
[...]
MBR, Sergei
| |