Messages in this thread | | | From | Paul Gortmaker <> | Date | Thu, 2 Feb 2017 15:07:01 -0500 | Subject | Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter |
| |
On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling <manuel.schoelling@gmx.de> wrote: > The impact of the persistent scrollback feature on the code size is > rather small, so the config option is removed. The feature stays > disabled by default and can be enabled by using the boot command line > parameter 'vgacon.scrollback_persistent=1' or by setting > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de> > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > ---
[...]
> +module_param_named(scrollback_persistent, scrollback_persistent, bool, 0000); > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent scrollback for all vga consoles");
Since this hasn't got widespread deployment yet and only exists in Greg's tree, can we please fix the above to use setup_param or similar, since there is nothing modular about this code at all.
Thanks. Paul.
| |