lkml.org 
[lkml]   [2017]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart
    On 四,  2月 16, 2017 at 02:31:38下午 +0100, Arnd Bergmann wrote:
    > On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote:
    > > static const struct of_device_id serial_ids[] = {
    > > - {.compatible = "sprd,sc9836-uart",},
    > > + {.compatible = "sprd,sc-uart",},
    > > {}
    >
    > We really need this to be specific, in case Spreadtrum ever
    > makes a slightly different UART that is not 100% compatible
    > with this one. Also, you can't remove the string you already have,
    > only add to it.
    >
    > Normally when you have a new chip that is compatible with one
    > we already have a driver for, we mark the device as compatible
    > with the old one and avoid having to change the driver, e.g.
    >
    > compatible = "sprd,sc9995-uart", "sprd,sc9836-uart";
    >
    > This way, the driver could later be changed to handle anything
    > that is compatible with sc9995 differently from sc9836, but
    > by default it would match the original string.
    >

    Right, I've addressed this when I received the same comments from
    Rob Herring :)

    Thanks for your comments,
    Chunyan

    > Arnd

    \
     
     \ /
      Last update: 2017-02-17 08:37    [W:2.615 / U:1.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site