lkml.org 
[lkml]   [2017]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] groups: don't return unmapped gids in getgroups(2)
On Fri, Feb 17, 2017 at 12:44 AM, Aleksa Sarai <asarai@suse.de> wrote:
>>> One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to
>>> disable setgroups on a per user namespace basis") is that because
>>> setgroups(2) no longer works in user namespaces it doesn't make any
>>> sense to be returning weird group IDs that the process cannot do
>>> anything with.
>>
>>

> bool DropPrivileges()
> {
> /* ... */
> // Verify that the user isn't still in any supplementary groups

But the user *is* still in a supplementary group. Your proposed
change would break the intent of this code.

\
 
 \ /
  Last update: 2017-02-17 18:10    [W:0.146 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site