lkml.org 
[lkml]   [2017]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 5/5] perf record: Add -a as a default target
    On Fri, Feb 17, 2017 at 11:28:14AM -0300, Arnaldo Carvalho de Melo wrote:
    > Em Fri, Feb 17, 2017 at 03:00:58PM +0100, Jiri Olsa escreveu:
    > > Adding system wide (-a) option as a default target
    > > if non is specified.
    > >
    > > # perf record
    > > Warning: No target specified, setting system-wide collection (-a).
    >
    > Ditto, this warning will get annoying after a while...

    ok, posting the change with no warning

    jirka

    ---
    Adding system wide (-a) option as a default target
    if non is specified.

    Running 'perf record' will now collect system wide data.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/n/tip-tq11of2qlz8kxpxzva05d54l@git.kernel.org
    ---
    tools/perf/Documentation/perf-record.txt | 2 +-
    tools/perf/builtin-record.c | 4 +++-
    2 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
    index 27256bc68eda..b16003ec14a7 100644
    --- a/tools/perf/Documentation/perf-record.txt
    +++ b/tools/perf/Documentation/perf-record.txt
    @@ -157,7 +157,7 @@ OPTIONS

    -a::
    --all-cpus::
    - System-wide collection from all CPUs.
    + System-wide collection from all CPUs (default if no target is specified).

    -p::
    --pid=::
    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 6cd6776052e7..b87bbef73394 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -1677,8 +1677,10 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)

    argc = parse_options(argc, argv, record_options, record_usage,
    PARSE_OPT_STOP_AT_NON_OPTION);
    +
    + /* Make system wide (-a) the default target. */
    if (!argc && target__none(&rec->opts.target))
    - usage_with_options(record_usage, record_options);
    + rec->opts.target.system_wide = true;

    if (nr_cgroups && !rec->opts.target.system_wide) {
    usage_with_options_msg(record_usage, record_options,
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-02-17 18:01    [W:2.113 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site