Messages in this thread Patch in this message | | | Date | Fri, 17 Feb 2017 02:06:56 +0530 | From | simran singhal <> | Subject | [PATCH v2 1/3] staging: rtl8192u: Replace symbolic permissions with octal permissions |
| |
Octal permissions should be used instead of symbolic ones for easier reading.
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. This warning is detected by checkpatch.pl
Signed-off-by: simran singhal <singhalsimran0@gmail.com> --- v2: -Added more information about patch -Reworked for putting proc_create() in one line drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index a9a92d8..503ba7f 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -283,8 +283,7 @@ int __init ieee80211_debug_init(void) " proc directory\n"); return -EIO; } - e = proc_create("debug_level", S_IRUGO | S_IWUSR, - ieee80211_proc, &fops); + e = proc_create("debug_level", 0644, ieee80211_proc, &fops); if (!e) { remove_proc_entry(DRV_NAME, init_net.proc_net); ieee80211_proc = NULL; -- 2.7.4
| |