Messages in this thread | | | Subject | Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() | From | Daniel Bristot de Oliveira <> | Date | Thu, 16 Feb 2017 18:35:54 +0100 |
| |
On 02/16/2017 03:34 AM, Byungchul Park wrote: > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task)) > when it returns a task other than NULL, which means that task_cpu(task) > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must > be rq->cpu as well. Remove the redundant condition and make code simpler. > > By this patch, unnecessary one branch and two LOAD operations in 'if' > statement can be avoided. > > Signed-off-by: Byungchul Park <byungchul.park@lge.com> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
+1
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
-- Daniel
| |