lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT] Networking
On Wed, Feb 15, 2017 at 5:31 PM, David Miller <davem@davemloft.net> wrote:
>
> 3) More gracefully handle rhashtable insertion errors when vmalloc is
> not possible, from Herbert Xu.

Ugh.

So I pulled this, but when I look at his code, I'm really not sure
that I should have, and I haven't pushed the result out. I'm pretty
sure I will unpull.

This code looks like it could *easily* have subtle issues, and looks
like the kind of thing that should go in a merge window.

The merge commit has this re-assuring sentence in it from Herbert:

"I've tested this with test_rhashtable and it appears to work."

and this is during the very last week of an rc release.

None of the commits even talk about why this was needed in the first
place, so there's no indication that this new scary code was really so
high-priority that it absolutely *has* to go into a late rc release.
None of it is marked for stable either, since networking never does
that.

So David, you really need to convince me that this pull is truly required.

Linus

\
 
 \ /
  Last update: 2017-02-16 03:02    [W:0.062 / U:27.772 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site