lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 199/306] PM / sleep: fix device reference leak in test_suspend
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream.

    Make sure to drop the reference taken by class_find_device() after
    opening the RTC device.

    Fixes: 77437fd4e61f (pm: boot time suspend selftest)
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    kernel/power/suspend_test.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/kernel/power/suspend_test.c
    +++ b/kernel/power/suspend_test.c
    @@ -169,8 +169,10 @@ static int __init test_suspend(void)

    /* RTCs have initialized by now too ... can we use one? */
    dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
    - if (dev)
    + if (dev) {
    rtc = rtc_class_open(dev_name(dev));
    + put_device(dev);
    + }
    if (!rtc) {
    printk(warn_no_rtc);
    goto done;
    \
     
     \ /
      Last update: 2017-02-16 01:32    [W:4.497 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site