lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 240/306] IB/core: Avoid unsigned int overflow in sg_alloc_table
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mark Bloch <markb@mellanox.com>

    commit 3c7ba5760ab8eedec01159b267bb9bfcffe522ac upstream.

    sg_alloc_table gets unsigned int as parameter while the driver
    returns it as size_t. Check npages isn't greater than maximum
    unsigned int.

    Fixes: eeb8461e36c9 ("IB: Refactor umem to use linear SG table")
    Signed-off-by: Mark Bloch <markb@mellanox.com>
    Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/infiniband/core/umem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/core/umem.c
    +++ b/drivers/infiniband/core/umem.c
    @@ -156,7 +156,7 @@ struct ib_umem *ib_umem_get(struct ib_uc

    cur_base = addr & PAGE_MASK;

    - if (npages == 0) {
    + if (npages == 0 || npages > UINT_MAX) {
    ret = -EINVAL;
    goto out;
    }
    \
     
     \ /
      Last update: 2017-02-16 01:30    [W:6.450 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site