lkml.org 
[lkml]   [2017]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 266/306] pwm: Fix device reference leak
    3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 0e1614ac84f1719d87bed577963bb8140d0c9ce8 upstream.

    Make sure to drop the reference to the parent device taken by
    class_find_device() after "unexporting" any children when deregistering
    a PWM chip.

    Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/pwm/sysfs.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/pwm/sysfs.c
    +++ b/drivers/pwm/sysfs.c
    @@ -356,6 +356,8 @@ void pwmchip_sysfs_unexport_children(str
    if (test_bit(PWMF_EXPORTED, &pwm->flags))
    pwm_unexport_child(parent, pwm);
    }
    +
    + put_device(parent);
    }

    static int __init pwm_sysfs_init(void)
    \
     
     \ /
      Last update: 2017-02-16 01:26    [W:3.830 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site