Messages in this thread | | | Date | Tue, 14 Feb 2017 09:19:14 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH] cpufreq: make ti-cpufreq explicitly non-modular |
| |
On 13-02-17, 19:45, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/cpufreq/Kconfig.arm:config ARM_TI_CPUFREQ > drivers/cpufreq/Kconfig.arm: bool "Texas Instruments CPUFreq support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Dave Gerlach <d-gerlach@ti.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > drivers/cpufreq/ti-cpufreq.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c > index 7ff7ae3c3911..a7b5658c0460 100644 > --- a/drivers/cpufreq/ti-cpufreq.c > +++ b/drivers/cpufreq/ti-cpufreq.c > @@ -17,7 +17,7 @@ > #include <linux/cpu.h> > #include <linux/io.h> > #include <linux/mfd/syscon.h> > -#include <linux/module.h> > +#include <linux/init.h> > #include <linux/of.h> > #include <linux/of_platform.h> > #include <linux/pm_opp.h> > @@ -265,8 +265,4 @@ static int ti_cpufreq_init(void) > > return ret; > } > -module_init(ti_cpufreq_init); > - > -MODULE_DESCRIPTION("TI CPUFreq/OPP hw-supported driver"); > -MODULE_AUTHOR("Dave Gerlach <d-gerlach@ti.com>"); > -MODULE_LICENSE("GPL v2"); > +device_initcall(ti_cpufreq_init);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
| |