Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 13 Feb 2017 16:18:06 +0100 | Subject | Re: linux-next: build failure after merge of the gpio tree |
| |
On Wed, Feb 8, 2017 at 6:11 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Linus, > > After merging the gpio tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/st-asc.c: In function 'asc_set_termios': > drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration] > gpiod = devm_get_gpiod_from_child(port->dev, "rts", > ^ > drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > gpiod = devm_get_gpiod_from_child(port->dev, "rts", > ^ > > Caused by commits > > a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO") > b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request") > 4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()") > > interacting with commit > > d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles") > > from the tty tree.
Ah what a bummer, a new user colliding with the treewide changes of these prototypes.
> I applied the following merge fix patch (I guessed about the new arguments):
Looks correct. Well not much to do about it apart from mentioning the problem to Linus (the big penguin) when merging the trees.
Thanks for your efforts!
Yours, Linus Walleij
| |