| Date | Mon, 13 Feb 2017 11:37:03 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH 17/33] irqchip/gic-v3-its: Add VLPI configuration hook |
| |
On Tue, 17 Jan 2017, Marc Zyngier wrote: > +static int its_irq_set_vcpu_affinity(struct irq_data *d, void *vcpu_info) > +{ > + struct its_device *its_dev = irq_data_get_irq_chip_data(d); > + struct its_cmd_info *info = vcpu_info; > + u32 event = its_get_event_id(d); > + > + /* Need a v4 ITS */ > + if (!its_dev->its->is_v4 || !info) > + return -EINVAL; > + > + switch (info->cmd_type) { > + case MAP_VLPI: > + {
Looking at the later patches which add functionality here, I'd rather avoid these massive case { } blocks and stick the functionality into seperate helper functions.
Thanks,
tglx
|