lkml.org 
[lkml]   [2017]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] sched/x86: Remove duplicated include from itmt.c

* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> arch/x86/kernel/itmt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/itmt.c b/arch/x86/kernel/itmt.c
> index f73f475..b5ccc9b 100644
> --- a/arch/x86/kernel/itmt.c
> +++ b/arch/x86/kernel/itmt.c
> @@ -20,7 +20,6 @@
> * frequency under ITMT.
> */
>
> -#include <linux/sched.h>
> #include <linux/cpumask.h>
> #include <linux/cpuset.h>
> #include <linux/mutex.h>

Firstly, we generally use 'larger' headers first, i.e. sched.h, mm.h, etc.

Secondly, this:

#include <linux/sched.h>
#include <linux/cpumask.h>
#include <linux/cpuset.h>
#include <linux/mutex.h>
#include <linux/sysctl.h>
#include <linux/nodemask.h>

... can probably be further reduced, because for example sched.h already includes
some of these headers.

I.e. instead of a mindless single liner that helps no-one, try to improve the code
for real...

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-02-10 09:19    [W:0.055 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site