Messages in this thread | | | Subject | Re: [PATCH] checkpatch: add warning on %pk instead of %pK usage | From | Joe Perches <> | Date | Fri, 10 Feb 2017 16:01:00 -0800 |
| |
On Fri, 2017-02-10 at 23:54 +0000, Roberts, William C wrote: > > The problem starts to get hairy when we think of how often folks roll their own > > logging macros (see some small sampling at the end).
It's not just the "hairy" local macros.
In its current form, checkpatch could not find uses like:
netif_<foo>(x, y, z, "some string with %pk", args); and some_logging_function(arg, "string 1" CONSTANT "string 2", etc...)
if string 2 or CONSTANT had the "%pk" use.
and a bunch of other styles.
This really needs to be verified by the compiler.
| |