lkml.org 
[lkml]   [2017]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit
From
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Thu, 9 Feb 2017 16:24:14 +0200

> @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> dev_warn(netcp->ndev_dev, "padding failed (%d), packet dropped\n",
> ret);
> tx_stats->tx_dropped++;
> - return ret;
> + return NETDEV_TX_BUSY;
> }
> skb->len = NETCP_MIN_PACKET_SIZE;
> }
> @@ -1329,7 +1330,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev)
> if (desc)
> netcp_free_tx_desc_chain(netcp, desc, sizeof(*desc));
> dev_kfree_skb(skb);
> - return ret;
> + return NETDEV_TX_BUSY;
> }

I really think these should be returning NET_XMIT_DROP.

\
 
 \ /
  Last update: 2017-02-10 20:45    [W:0.039 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site