[lkml]   [2017]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/3] fix few OOM victim allocation runaways
these three patches tried to address a simple OOM victim runaways when
the oom victim can deplete the memory reserve completely. Tetsuo was able
to trigger the depletion in the write(2) path and I believe the similar
is possible for the read part. Vmalloc would be a bit harder but still
not impossible.

Unfortunately I do not see a better way around this issue as long as we
give OOM victims access to memory reserves without any limits. I have
tried to limit this access [1] which would help at least to keep some
memory for emergency actions. Anyway, even if we limit the amount of
reserves the OOM victim can consume it is still preferable to back off
before accessible reserves are depleted.

Tetsuo was suggesting introducing __GFP_KILLABLE which would fail the
allocation rather than consuming the reserves. I see two problems with
this approach.
1) in order this flags work as expected all the blocking
operations in the allocator call chain (including the direct
reclaim) would have to be killable and this is really non
trivial to achieve. Especially when we do not have any control
over shrinkers.
2) even if the above could be dealt with we would still have to
find all the places which do allocation in the loop based on
the user request. So it wouldn't be simpler than an explicit
fatal_signal_pending check.

Michal Hocko (3):
fs: break out of iomap_file_buffered_write on fatal signals
mm, fs: check for fatal signals in do_generic_file_read
vmalloc: back of when the current is killed

fs/dax.c | 5 +++++
fs/iomap.c | 3 +++
mm/filemap.c | 5 +++++
mm/vmalloc.c | 5 +++++
4 files changed, 18 insertions(+)


 \ /
  Last update: 2017-02-01 10:29    [W:0.064 / U:4.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site