lkml.org 
[lkml]   [2017]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)
From
Date
On Wed, 2017-02-01 at 18:36 +0200, Martin Karamihov wrote:
>
> On 02/01/2017 12:39 AM, Joe Perches wrote:
> > On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
> > > This is checkpatch fix for hal/bb_cfg.c file:
> > > remove not necessary braces {}
> > >
> > > Signed-off-by: Martin Karamihov <martinowar@gmail.com>
> > > ---
> > > drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > index 134fa6c595a8..26e0ef224299 100644
> > > --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> > > @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
> > > power_level_offset[11] = data;
> > > if (regaddr == rTxAGC_B_Mcs11_Mcs08)
> > > power_level_offset[12] = data;
> > > - if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
> > > + if (regaddr == rTxAGC_B_Mcs15_Mcs12)
> > > power_level_offset[13] = data;
> > > - }
> >
> > presumably, this and the regaddr block above it
> > should be an else if or a switch/case.
> >
> I will prepare the patch if this code modification is needed right now.
> Is it?

No more nor less than the suggested brace removal.
Do please remember (or learn) that checkpatch is
a brainless script and clarifying the code for a
human reader is much more important than making a
file not have any checkpatch warnings.

\
 
 \ /
  Last update: 2017-02-01 19:12    [W:0.041 / U:27.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site