Messages in this thread | | | Date | Wed, 1 Feb 2017 19:17:12 +0530 | From | Amit Shah <> | Subject | Re: [PATCH] virtio-console: avoid DMA from stack |
| |
On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote: > From: Omar Sandoval <osandov@fb.com> > > put_chars() stuffs the buffer it gets into an sg, but that buffer may be > on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it > manifested as printks getting turned into NUL bytes).
Seems reasonable. I wonder since all implementations of hvc do a memcpy, if we can abstract it - but that'll need some work.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Michael, please add to the virtio queue.
Amit
| |