lkml.org 
[lkml]   [2017]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present
On 26 January 2017 at 17:45, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
>> Some Asus laptops that have an airplane-mode indicator LED, also have
>> the WMI WLAN user bit set, and the following bits in their DSDT:
>
> style trivia:
>
>> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> []
>> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
>> return 0;
>> }
>>
>> +static bool ashs_present(void)
>> +{
>> + int i;
>> +
>> + for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
>> + if (acpi_dev_found(asus_wireless_ids[i].id))
>> + return true;
>
> The for loop would commonly have braces because of the
> internal if.
>

Thanks, I'm fixing it for the next revision.

--
João Paulo Rechi Vita
http://about.me/jprvita

\
 
 \ /
  Last update: 2017-02-01 13:20    [W:0.052 / U:1.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site