lkml.org 
[lkml]   [2017]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] iio: pressure: mpl3115: do not rely on structure field ordering
From
Date
On 2017-02-01 10:57, Peter Meerwald-Stadler wrote:
>>> - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
>>> BIT(IIO_CHAN_INFO_SCALE),
>>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
>>> BIT(IIO_CHAN_INFO_SCALE),
>>> as originally intended
>>
>> I considered that option, but the code in mpl3115_read_raw (and
>> mpl115_read_raw for that matter) return constants fro these values which
>> to me indicated that they were not "separate" and as that would also be
>> the change which replicated the exact behavior from before the regression
>> I went with that. But I don't care either way, so I can re-spin if you
>> want me to? (But don't blame me if that regresses in some other
>> interesting way).
>
> no, all good; shared_by_type is the way to go
> I'd rather respin for the not ORed comment in the patch

Ok, but I think I'll wait a bit so that Ken Lin gets some time to verify
that it actually solves the original problem. It should, but...

Cheers,
peda

\
 
 \ /
  Last update: 2017-02-01 11:19    [W:0.048 / U:9.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site