Messages in this thread | | | Date | Wed, 1 Feb 2017 11:08:57 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 4/5] xen, x86/headers: Add <linux/device.h> dependency to <asm/xen/page.h> |
| |
* Juergen Gross <jgross@suse.com> wrote:
> On 01/02/17 10:51, Ingo Molnar wrote: > > The following patch (not upstream yet): > > > > "x86/boot/e820: Remove spurious asm/e820/api.h inclusions" > > > > Removed the (spurious) <asm/e820.h> include line from <asm/pgtable.h> to > > reduce header file dependencies - but a Xen header has (unintentionally) > > learned to rely on the indirect inclusion of <linux/device.h>. > > > > This resulted in the following (harmless) build warning: > > > > arch/x86/include/asm/xen/page.h:302:7: warning: 'struct device' declared inside parameter list > > > > Include <linux/device.h> explicitly. > > > > No change in functionality. > > > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Cc: <stefano.stabellini@eu.citrix.com> > > Cc: Juergen Gross <jgross@suse.com> > > Hmm, how did you send this? In spite of the Cc: list in the patch only > few of those listed here are included in the Cc: header of the mail.
I restricted it explicitly in the sending script to those I thought might be interested in the series, as LKML (and/or gmail) would occasionally reject a mail based on too many Cc: entries...
Note that the tip-bot notification would still have Cc:-ed everyone mentioned in the Cc: lists, so had I screwed up the patch you'd still have been informed and you'd have the opportunity to embarrass me! :-)
> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Ingo Molnar <mingo@kernel.org> > > Acked-by: Juergen Gross <jgross@suse.com>
Thanks! Added this to the changelog.
Ingo
| |