Messages in this thread | | | Subject | Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell | From | Joe Perches <> | Date | Fri, 08 Dec 2017 14:20:59 -0800 |
| |
On Fri, 2017-12-08 at 14:02 -0800, Andrew Morton wrote: > On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote: > > > On (12/08/17 17:37), Liu, Changcheng wrote: > > > > > > On some linux distributions, the default link of sh > > > is dash which deoesn't support split array like > > > ${var//,/ } > > > It's better to force to use bash shell directly. > > > > > > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com> > > > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > It would be better to rewrite the script to avoid bashisms. But... > > akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l > 164 > > I guess we lost that fight a long time ago.
103 of those are in tools/ and I don't think those count. If you take out samples/ and Documentation/ it's down to 24.
| |