lkml.org 
[lkml]   [2017]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tools/slabinfo-gnuplot: force to use bash shell
From
Date
On Fri, 2017-12-08 at 14:02 -0800, Andrew Morton wrote:
> On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
>
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > >
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > >
> > > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> >
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>
> It would be better to rewrite the script to avoid bashisms. But...
>
> akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
> 164
>
> I guess we lost that fight a long time ago.

103 of those are in tools/ and I don't think those count.
If you take out samples/ and Documentation/ it's down to 24.

\
 
 \ /
  Last update: 2017-12-08 23:21    [W:0.048 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site