Messages in this thread Patch in this message | | | From | "Moore, Robert" <> | Subject | RE: [PATCH] ACPICA: Fix indentation | Date | Fri, 8 Dec 2017 21:13:15 +0000 |
| |
This type of thing more often than not is caused by running the code through indent (lindent).
Original ACPICA code:
ACPI_FUNCTION_NAME (ExDumpOperand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) { return; }
Raw "linuxized" code:
ACPI_FUNCTION_NAME (ex_dump_operand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) { return; }
> -----Original Message----- > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of > Rafael J. Wysocki > Sent: Friday, December 8, 2017 9:06 AM > To: Vasyl Gomonovych <gomonovych@gmail.com> > Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv > <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; > Len Brown <lenb@kernel.org>; ACPI Devel Maling List <linux- > acpi@vger.kernel.org>; devel@acpica.org; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; Schmauss, Erik <erik.schmauss@intel.com> > Subject: Re: [PATCH] ACPICA: Fix indentation > > On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com> > wrote: > > This patch avoids that smatch reports the following: > > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: > > inconsistent indenting > > > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> > > This is ACPICA code, so changes like this should go in via the upstream. > > Erik may want to pick this up, however. > > > --- > > drivers/acpi/acpica/exdump.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/acpica/exdump.c > > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644 > > --- a/drivers/acpi/acpica/exdump.c > > +++ b/drivers/acpi/acpica/exdump.c > > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union > > acpi_operand_object *obj_desc, u32 depth) > > > > ACPI_FUNCTION_NAME(ex_dump_operand) > > > > - /* Check if debug output enabled */ > > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > + /* Check if debug output enabled */ > > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > return; > > } > > > > --
| |