Messages in this thread Patch in this message | | | Subject | [PATCH 2/4] serial: pch_uart: Use kcalloc() in dma_handle_tx() | From | SF Markus Elfring <> | Date | Fri, 8 Dec 2017 19:10:32 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 8 Dec 2017 18:38:15 +0100
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/tty/serial/pch_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 0fc72c491c9b..53cdf23b83c6 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -991,7 +991,7 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv) priv->tx_dma_use = 1; - priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC); + priv->sg_tx_p = kcalloc(num, sizeof(*priv->sg_tx_p), GFP_ATOMIC); if (!priv->sg_tx_p) return 0; -- 2.15.1
| |