lkml.org 
[lkml]   [2017]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v1 1/2] eeprom: at24: convert magic numbers to structs.
    From
    Date
    On 2017-12-08 16:28, Sven Van Asbroeck wrote:
    > Bartosz wrote:
    >> Just make it accept two parameters: the string and the data object
    >> name. For example:
    >>
    >> AT24_OF_DEVICE_ID("atmel,24c01", 24c01);
    >>
    >
    > I don't want to do too much bikeshedding,
    > but one last comment.
    >
    > Is it a good idea to have duplicated information?
    > Do you think the risk of a typo mismatch is acceptable? E.g.
    > AT24_OF_DEVICE_ID("atmel,24c01", 24c02);
    >
    > At least the original syntax is not susceptible to this problem,
    > but of course as you say, it hides the of_ compatible string:
    > AT24_OF_DEVICE_ID(atmel, 24c01);
    > /* hides 'atmel,24c01' */

    It's nice to be able to grep for compatible strings.

    $.02

    /peda

    \
     
     \ /
      Last update: 2017-12-08 16:41    [W:6.320 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site