[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 01/10] staging: ccree: remove inline qualifiers
On Mon, Dec 4, 2017 at 11:36 AM, Dan Carpenter <> wrote:
> On Sun, Dec 03, 2017 at 01:58:12PM +0000, Gilad Ben-Yossef wrote:
>> The ccree drivers was marking a lot of big functions in C file as
>> static inline for no good reason. Remove the inline qualifier from
>> any but the few truly single line functions.
> The compiler is free to ignore inline hints... It probably would make
> single line functions inline anyway.

Yes. I think of it more as a note to the reader: "don't add stuff to
this function. it is meant to be short and simple".

Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru

 \ /
  Last update: 2017-12-07 08:01    [W:0.045 / U:2.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site