Messages in this thread | | | Subject | Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback | From | Sinan Kaya <> | Date | Thu, 7 Dec 2017 09:45:31 -0500 |
| |
On 12/7/2017 8:10 AM, Lothar Waßmann wrote: >> +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, >> + struct device *dev) > Shouldn't this be 'const void *of_fwnode_get_match_data
OF keeps the driver data as a (const void*) internally. ACPI keeps the driver data as kernel_ulong_t in struct acpi_device_id.
I tried to find the middle ground here by converting output to void* but not keeping const.
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |