lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 047/109] be2net: fix unicast list filling
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ivan Vecera <cera@cera.cz>


    [ Upstream commit 6052cd1af86f9833b6b0b60d5d4787c4a06d65ea ]

    The adapter->pmac_id[0] item is used for primary MAC address but
    this is not true for adapter->uc_list[0] as is assumed in
    be_set_uc_list(). There are N UC addresses copied first from net_device
    to adapter->uc_list[1..N] and then N UC addresses from
    adapter->uc_list[0..N-1] are sent to HW. So the last UC address is never
    stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
    instead.

    Cc: Sathya Perla <sathya.perla@broadcom.com>
    Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
    Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
    Cc: Somnath Kotur <somnath.kotur@broadcom.com>
    Fixes: b717241 be2net: replace polling with sleeping in the FW completion path
    Signed-off-by: Ivan Vecera <cera@cera.cz>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/emulex/benet/be_main.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/net/ethernet/emulex/benet/be_main.c
    +++ b/drivers/net/ethernet/emulex/benet/be_main.c
    @@ -1719,9 +1719,8 @@ static void be_set_uc_list(struct be_ada
    }

    if (adapter->update_uc_list) {
    - i = 1; /* First slot is claimed by the Primary MAC */
    -
    /* cache the uc-list in adapter array */
    + i = 0;
    netdev_for_each_uc_addr(ha, netdev) {
    ether_addr_copy(adapter->uc_list[i].mac, ha->addr);
    i++;

    \
     
     \ /
      Last update: 2017-12-07 15:29    [W:4.179 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site