Messages in this thread | | | Date | Thu, 7 Dec 2017 16:17:11 +1100 | From | "Tobin C. Harding" <> | Subject | Re: [PATCH V11 4/5] vsprintf: add printk specifier %px |
| |
On Wed, Dec 06, 2017 at 05:45:37PM +0900, Sergey Senozhatsky wrote: > On (12/06/17 09:32), Geert Uytterhoeven wrote: > [..] > > >> show_fault_oops(struct pt_regs *regs, unsigned long error_code, > > >> unsigned long address) > > >> ... > > >> printk(KERN_CONT " at %p\n", (void *) address); > > >> printk(KERN_ALERT "IP: %pS\n", (void *)regs->ip); > > > > > > So %pS isn't %p, and shows the symbolic name. > > > > If the symbolic name is available. > > Else it prints the non-hashed pointer value (FTR).
Well, this
[RFC 0/3] kallsyms: don't leak address when printing symbol
_trys_ to fix that
> hm, indeed. and !CONFIG_KALLSYMS config turns %pS/%ps > into special_hex_number().
But totally misses this :(
"<no-sym>" would be better returned when !CONFIG_KALLSYMS, right?
thanks, Tobin.
| |