lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 10/26] vti6: fix device register to report IFLA_INFO_KIND
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Forster <dforster@brocade.com>


    [ Upstream commit 93e246f783e6bd1bc64fdfbfe68b18161f69b28e ]

    vti6 interface is registered before the rtnl_link_ops block
    is attached. As a result the resulting RTM_NEWLINK is missing
    IFLA_INFO_KIND. Re-order attachment of rtnl_link_ops block to fix.

    Signed-off-by: Dave Forster <dforster@brocade.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv6/ip6_vti.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv6/ip6_vti.c
    +++ b/net/ipv6/ip6_vti.c
    @@ -172,12 +172,12 @@ static int vti6_tnl_create2(struct net_d
    struct vti6_net *ip6n = net_generic(net, vti6_net_id);
    int err;

    + dev->rtnl_link_ops = &vti6_link_ops;
    err = register_netdevice(dev);
    if (err < 0)
    goto out;

    strcpy(t->parms.name, dev->name);
    - dev->rtnl_link_ops = &vti6_link_ops;

    dev_hold(dev);
    vti6_tnl_link(ip6n, t);

    \
     
     \ /
      Last update: 2017-12-07 13:56    [W:4.116 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site