lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata
    Date
    Hi Nickey,

    platform_set_drvdata() is still missing in your version.

    Thanks,
    Philippe :-)

    On 12/06/2017 10:39 PM, Brian Norris wrote:
    > On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote:
    >> From: Brian Norris <briannorris@chromium.org>
    >>
    >> Bridge drivers/helpers shouldn't be clobbering the drvdata, since a
    >> parent driver might need to own this. Instead, let's return our
    >> 'dw_mipi_dsi' object and have callers pass that back to us for removal.
    >>
    >> Signed-off-by: Brian Norris <briannorris@chromium.org>
    >> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
    >> Link:https://patchwork.kernel.org/patch/10078493/
    >>
    >> ---
    >> Changes
    >>
    >> v4:
    >> - Add From tag,update subject line
    >> - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove"
    >> in this piece together.
    >>
    >> v5:
    >> - remove Review & Ack tag
    >> - fix remove() directly referencing the static
    >> dw_mipi_dsi_stm_plat_data struct.
    >
    > You've gotten this back into basically the shape I sent v1 in, so I
    > guess this deserves an:
    >
    > Acked-by: Brian Norris <briannorris@chromium.org>
    >
    > :)
    >
    > Only net changes: you renamed the 'dsi' field to 'dmd' (Dwc Mipi
    > Device?), and my 'return 0' changed back to the original 'return ret' at
    > the end of probe(). Doesn't make any functional difference, so fine with
    > me.
    >
    > If everybody's just as happy with this as with the first
    > version...should it just be applied now, regardless of the status of the
    > next 2 patches? Could help reduce the discussion (and confusion)
    > surface.
    >
    > Regards,
    > Brian
    >
    >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 ++++++++++-----------------
    >> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 10 +++++---
    >> include/drm/bridge/dw_mipi_dsi.h | 17 ++++++++-----
    >> 3 files changed, 30 insertions(+), 33 deletions(-)
    > ...
    >
    \
     
     \ /
      Last update: 2017-12-07 12:42    [W:4.022 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site