lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 087/135] scsi: hpsa: cleanup sas_phy structures in sysfs when unloading
    Date
    From: Martin Wilck <mwilck@suse.de>

    [ Upstream commit 55ca38b4255bb336c2d35990bdb2b368e19b435a ]

    I am resubmitting this patch on behalf of Martin Wilck with his
    permission.

    The original patch can be found here:
    https://www.spinics.net/lists/linux-scsi/msg102083.html

    This patch did not help until Hannes's
    commit 9441284fbc39 ("scsi-fixup-kernel-warning-during-rmmod")
    was applied to the kernel.

    --------------------------------------
    Original patch description from Martin:
    --------------------------------------

    When the hpsa module is unloaded using rmmod, dangling
    symlinks remain under /sys/class/sas_phy. Fix this by
    calling sas_phy_delete() rather than sas_phy_free (which,
    according to comments, should not be called for PHYs that
    have been set up successfully, anyway).

    Tested-by: Don Brace <don.brace@microsemi.com>
    Reviewed-by: Don Brace <don.brace@microsemi.com>
    Signed-off-by: Martin Wilck <mwilck@suse.de>
    Signed-off-by: Don Brace <don.brace@microsemi.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/scsi/hpsa.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
    index 4ed3d26ffdde..832bc83fcd8e 100644
    --- a/drivers/scsi/hpsa.c
    +++ b/drivers/scsi/hpsa.c
    @@ -9207,9 +9207,9 @@ static void hpsa_free_sas_phy(struct hpsa_sas_phy *hpsa_sas_phy)
    struct sas_phy *phy = hpsa_sas_phy->phy;

    sas_port_delete_phy(hpsa_sas_phy->parent_port->port, phy);
    - sas_phy_free(phy);
    if (hpsa_sas_phy->added_to_port)
    list_del(&hpsa_sas_phy->phy_list_entry);
    + sas_phy_delete(phy);
    kfree(hpsa_sas_phy);
    }

    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-07 18:54    [W:4.111 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site