lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 110/135] rtl8188eu: Fix a possible sleep-in-atomic bug in rtw_disassoc_cmd
    Date
    From: Jia-Ju Bai <baijiaju1990@163.com>

    [ Upstream commit 08880f8e08cbd814e870e9d3ab9530abc1bce226 ]

    The driver may sleep under a spinlock, and the function call path is:
    rtw_set_802_11_bssid(acquire the spinlock)
    rtw_disassoc_cmd
    kzalloc(GFP_KERNEL) --> may sleep

    To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.
    This bug is found by my static analysis tool and my code review.

    Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
    index 430b8eb58976..be8542676adf 100644
    --- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
    +++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
    @@ -508,7 +508,7 @@ u8 rtw_disassoc_cmd(struct adapter *padapter, u32 deauth_timeout_ms, bool enqueu

    if (enqueue) {
    /* need enqueue, prepare cmd_obj and enqueue */
    - cmdobj = kzalloc(sizeof(*cmdobj), GFP_KERNEL);
    + cmdobj = kzalloc(sizeof(*cmdobj), GFP_ATOMIC);
    if (!cmdobj) {
    res = _FAIL;
    kfree(param);
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-12-07 18:48    [W:4.069 / U:1.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site