lkml.org 
[lkml]   [2017]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 06/35] nds32: MMU fault handling and page table management
    On Mon, Nov 27, 2017 at 08:27:53PM +0800, Greentime Hu wrote:
    > +void do_page_fault(unsigned long entry, unsigned long addr,
    > + unsigned int error_code, struct pt_regs *regs)
    [snip]
    > + /*
    > + * If we're in an interrupt or have no user
    > + * context, we must not take the fault..
    > + */
    > + if (unlikely(in_atomic() || !mm))

    Broken. in_atomic() is wrong here - it should be faulthandler_disabled().

    \
     
     \ /
      Last update: 2017-12-07 17:42    [W:3.327 / U:1.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site