lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer()
From
Date
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.

Markus' typical terrible commit message.

> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
> > */
> > clear = kmalloc(sizeof *clear, GFP_ATOMIC);
> > if (clear == NULL) {
> > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
> > /* FIXME recover somehow ... RESET_TT? */
> > return -ENOMEM;
> > }
>
> Does the existing memory allocation error message include the
> &udev->dev device name and driver name? If it doesn't, there will be
> no way for the user to tell that the error message is related to the
> device failure.

No, but the effect is similar.

OOM does a dump_stack() so this function's call tree is shown.

\
 
 \ /
  Last update: 2017-12-06 21:05    [W:0.062 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site