Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Wed, 6 Dec 2017 17:41:32 +0100 | Subject | Re: [PATCH] ACPI / GED: unregister interrupts during shutdown |
| |
On Wed, Dec 6, 2017 at 5:11 PM, Sinan Kaya <okaya@codeaurora.org> wrote: > On 12/6/2017 9:57 AM, Sinan Kaya wrote: >>> Yes, it should, so I'm not sure why you need the list in the first place. >>> >>> Also it looks like something along the lines of devres_release_all() >>> should be sufficient. >> Good suggestion, let me test this. >> > > I tried to pull the code into GED but the API is not public. I also looked > at how it is used. I was afraid to mess up with the internals of base.c by > calling devres_release_all() externally first and by the driver framework > next. I moved away from this approach.
Are you sure it is called by the core in the shutdown path?
> I just fixed the function rename and changed the dev_info() to dev_dbg().
And why do you need the list?
ged_shutdown() will be called for every device for which ged_probe() has been called.
| |