lkml.org 
[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BUG: KASAN: slab-out-of-bounds in perf_callchain_user+0x494/0x530
On Wed, Dec 06, 2017 at 11:31:30PM +0900, Namhyung Kim wrote:

> > There's also a race against put_callchain_buffers() there, consider:
> >
> >
> > get_callchain_buffers() put_callchain_buffers()
> > mutex_lock();
> > inc()
> > dec_and_test() // false
> >
> > dec() // 0
> >
> >
> > And the buffers leak.
>
> Hmm.. did you mean that get_callchain_buffers() returns an error?

Yes, get_callchain_buffers() fails, but while doing so it has a
temporary increment on the count.

> AFAICS it cannot fail when it sees count > 1 (and callchain_cpus_
> entries is allocated).

It can with your patch. We only test event_max_stack against the sysctl
after incrementing.

\
 
 \ /
  Last update: 2017-12-06 16:47    [W:0.178 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site