Messages in this thread | | | Subject | Re: [PATCH] usb: core: Add "quirks" parameter for usbcore | From | Kai Heng Feng <> | Date | Wed, 6 Dec 2017 17:27:35 +0800 |
| |
> On 6 Dec 2017, at 5:13 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: >> +/* Works only for digits and letters, but small and fast */ >> +#define TOLOWER(x) ((x) | 0x20) > > What is wrong with the in-kernel version of tolower()?
Nothing’s wrong with the in-kernel version. I’ll use that in v2.
Other than that, is there anythings I can make to improve the code?
Kai-Heng
> > thanks, > > greg k-h
| |