Messages in this thread | | | Subject | Re: [PATCH] watchdog: hpwdt: fix unused variable warning | From | Guenter Roeck <> | Date | Wed, 6 Dec 2017 20:36:31 -0800 |
| |
On 12/06/2017 01:02 PM, Arnd Bergmann wrote: > The new hpwdt_my_nmi() function is used conditionally, which produces > a harmless warning in some configurations: > > drivers/watchdog/hpwdt.c:478:12: error: 'hpwdt_my_nmi' defined but not used [-Werror=unused-function] > > This moves it inside of the #ifdef that protects its caller, to silence > the warning. > > Fixes: 621174a92851 ("watchdog: hpwdt: Check source of NMI") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/hpwdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index e61658310381..f1f00dfc0e68 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -475,12 +475,12 @@ static int hpwdt_time_left(void) > return TICKS_TO_SECS(ioread16(hpwdt_timer_reg)); > } > > +#ifdef CONFIG_HPWDT_NMI_DECODING > static int hpwdt_my_nmi(void) > { > return ioread8(hpwdt_nmistat) & 0x6; > } > > -#ifdef CONFIG_HPWDT_NMI_DECODING > /* > * NMI Handler > */ >
| |