[lkml]   [2017]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 4/4] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC
Yixun Lan <> writes:

> From: Qiufang Dai <>
> Try to add Hiubus DT info, and also enable clock DT info
> for the Amlogic's Meson-AXG SoC.
> Acked-by: Rob Herring <>
> Signed-off-by: Qiufang Dai <>
> Signed-off-by: Yixun Lan <>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index b932a784b02a..36a2e98338a8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -7,6 +7,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clock/axg-clkc.h>

This #include will cause an unnessary dependency from the amlogic tree
to the clock tree even though this patch is not currently using any of
the #defines from that header. It will simplify the dependencies if you
drop this #include from this patch.

In my comment on the cover letter, I suggested adding a patch that also
switches the UART over to the new clock provider. That is the patch
that should add this #include, since it will actually need #defines from
the header.

Doing it in that order means that we could merge this patch
independently of the clock driver, and then merge the UART switch-over
patch only after the driver (and headers) are merged.


 \ /
  Last update: 2017-12-07 01:50    [W:0.085 / U:3.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site