Messages in this thread | | | From | Tyler Baker <> | Date | Tue, 5 Dec 2017 12:58:44 -0800 | Subject | Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts |
| |
On Fri, Dec 1, 2017 at 12:10 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Thu, Nov 30, 2017 at 6:14 PM, <tyler@opensourcefoundries.com> wrote: > >> +&ecspi3 { >> + fsl,spi-num-chipselects = <1>; > > Please remove this property. It is no longer used.
Ack.
> > >> + dvicape@39 { >> + compatible = "sil164_simple"; > > This compatible string does not exist.
I'm going to drop this, and address the display hardware it in a later series.
> > > >> +&lcdif { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_lcdif_dat >> + &pinctrl_lcdif_ctrl>; >> + display = <&display0>; >> + status = "okay"; >> + >> + display0: display { >> + bits-per-pixel = <24>; >> + bus-width = <24>; >> + >> + display-timings { >> + native-mode = <&timing0>; >> + timing0: dvi { >> + /* 1024x768p60 */ >> + clock-frequency = <65000000>; >> + hactive = <1024>; >> + hfront-porch = <40>; >> + hback-porch = <220>; >> + hsync-len = <60>; >> + vactive = <768>; >> + vfront-porch = <7>; >> + vback-porch = <21>; >> + vsync-len = <10>; >> + >> + hsync-active = <0>; >> + vsync-active = <0>; >> + de-active = <1>; >> + pixelclk-active = <0>; > > Which panel is this? Could you use a simple panel driver compatible > string instead?
I'll switch to a simple panel driver and do some more testing. Will submit a follow up series to address the LCD panel and dvi cape.
> > >> + }; >> + }; >> + }; >> +}; >> + >> +&uart2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_uart2>; >> + assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>; >> + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>; >> + fsl,uart-has-rtscts; > > Please use 'uart-has-rtscts' instead.
Ack.
> >> + status = "okay"; >> +}; >> + >> +&uart5 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_uart5>; >> + assigned-clocks = <&clks IMX7D_UART5_ROOT_SRC>; >> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>; >> + fsl,uart-has-rtscts; > > Ditto.
Ack.
> >> + status = "okay"; >> +}; >> + >> +&uart7 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_uart7>; >> + assigned-clocks = <&clks IMX7D_UART7_ROOT_SRC>; >> + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>; >> + fsl,uart-has-rtscts; > > Ditto
Ack.
| |