lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pata_pdc2027x: Fix coding sytle error
Date
On Tuesday, December 05, 2017 03:02:13 PM Bartlomiej Zolnierkiewicz wrote:
> On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote:
> > Fix these checkpatch.pl error:
> > ERROR: space prohibited before open square bracket '['.
> >
> > ERROR: space prohibited after that '~' (ctx:WxW)
> > + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> >
> > ERROR: spaces required around that '?' (ctx:VxW)
> > + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> >
> > ERROR: that open brace { should be on the previous line
> > + const struct ata_port_info *ppi[] =
> > + { &pdc2027x_port_info[board_idx], NULL };
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

PS two small things than still can be fixed:

* s/sytle error/style errors/ in the patch summary

* s/error/errors/ in the patch description

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

\
 
 \ /
  Last update: 2017-12-05 15:12    [W:0.081 / U:2.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site