Messages in this thread | | | Subject | Re: [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level | From | "Maciej S. Szmigiero" <> | Date | Tue, 5 Dec 2017 14:01:17 +0100 |
| |
Hi Nicolin,
On 04.12.2017 21:46, Nicolin Chen wrote: > ==Background== > The fsl_ssi driver was designed for PPC originally and then it has > been updated to support different modes for i.MX Series, including > SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different > contributors for different use cases in different coding styles. > > Additionally, in order to fix/work-around hardware bugs and design > flaws, the driver made a lot of compromise so now its program flow > looks very complicated and it's getting hard to maintain or update. > > So I am going to clean up the driver in both coding style level and > program flow level. > > ==Introduction== > This series of patches is the first set to clean up fsl_ssi driver > in the coding style level. Any patch here is not supposed to change > the program flow. > > ==Verification== > Theoretically, it only needs code review, build and sanity tests. I > have done build and sanity tests on an i.MX 6 platform by building > using imx_v6_v7_defconfig and testing with I2S slave/master mode.
Thanks for your cleanup work.
Due to my current workload I will be able to go through this and test the AC'97 mode on a UDOO board only in about a week.
Maciej
| |