lkml.org 
[lkml]   [2017]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scripts/faddr2line: extend usage on generic arch
On 22:30 Tue 05 Dec, Richard Weinberger wrote:
> On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng
> <changcheng.liu@intel.com> wrote:
> > fadd2line script should use the binary tool
> > used for the target system.
> >
> > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> >
> > diff --git a/scripts/faddr2line b/scripts/faddr2line
> > index 1f5ce95..39e07d8 100755
> > --- a/scripts/faddr2line
> > +++ b/scripts/faddr2line
> > @@ -44,9 +44,16 @@
> > set -o errexit
> > set -o nounset
> >
> > +READELF="${CROSS_COMPILE}readelf"
> > +ADDR2LINE="${CROSS_COMPILE}addr2line"
> > +SIZE="${CROSS_COMPILE}size"
> > +NM="${CROSS_COMPILE}nm"
>
> How is this supposed to work when not cross compiling?
> When CROSS_COMPILE is not set this script will terminate because of
> the "set -o nounset" bash setting...

[Changcheng]:@Richard. Thx for your check. I've sent the fix patch to
resolve the unbound variable error.

>
> --
> Thanks,
> //richard

\
 
 \ /
  Last update: 2017-12-06 02:37    [W:0.034 / U:2.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site