lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 09/22] mmc: tmio: use mmc_can_gpio_cd() instead of checking TMIO_MMC_USE_GPIO_CD
    On Sat, Nov 25, 2017 at 01:24:44AM +0900, Masahiro Yamada wrote:
    > To use a GPIO line for card detection, TMIO_MMC_USE_GPIO_CD is set
    > by a legacy board (arch/sh/boards/mach-ecovec24).
    >
    > For DT platforms, the "cd-gpios" property is a legitimate way for that
    > in case the IP-builtin card detection can not be used for some reason.
    > mmc_of_parse() calls mmc_gpiod_request_cd() to set up ctx->cd_gpio if
    > the "cd-gpios" property is specified.
    >
    > To cater to both cases, mmc_can_gpio_cd() is a correct way to check
    > which card detection logic is used.
    >
    > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

    My gut feeling is that your patch is correct, but I need to have another
    look at this native_hotplug code with a fresh brain and take your other
    patches into account as well then, too.

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-12-04 23:22    [W:4.041 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site