lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] eeprom: at24: Change nvmem stride to 1
From
Date
On 12/04/2017 11:44 AM, Bartosz Golaszewski wrote:
> I can't find any documentation on what the stride config option does
> in nvmem, but looking at the code it's only used for alignment checks
> in nvmem core, so this patch should be ok. Still: I'm wondering if it
> shouldn't depend on the size of the eeprom or if we shouldn't make the
> chip you're using a special case.

I am just guessing on the usage too, but I assume it is for memory
alignment for other types of nvmem devices that only read words (2, 4 or
8 bytes) at a time. I don't see anything in the at24 code that says we
can't read any arbitrary starting I2C register, so I don't think we
should have any problems.

>
> @David: what is the chip you're using?

Microchip 24FC128

> Is it an at24mac402 by any
> chance? Were you affected by the read problem we fixed recently[1][2]
> in at24?

No and no.

>
> @Srinivas: any comments on that?
>
> Thanks,
> Bartosz
>
> [1] http://patchwork.ozlabs.org/patch/841852/
> [2] http://patchwork.ozlabs.org/patch/841876/
>

\
 
 \ /
  Last update: 2017-12-04 22:23    [W:0.053 / U:53.992 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site