lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()
On Fri, Dec 01, 2017 at 08:45:13PM -0800, Joe Perches wrote:
> On Fri, 2017-12-01 at 13:44 -0800, Paul E. McKenney wrote:

[ . . . ]

> > Good points! Like this?
> []
> > commit ff155ce179aab891dbe2ca80f82a453383fd165a
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date: Mon Nov 27 09:37:35 2017 -0800
> >
> > checkpatch: Add warnings for {smp_,}read_barrier_depends()
> >
> > Now that both smp_read_barrier_depends() and read_barrier_depends()
> > are being de-emphasized, warn if any are added.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Cc: Andy Whitcroft <apw@canonical.com>
> > Cc: Joe Perches <joe@perches.com>
> > [ paulmck: Skipped checking files and handled whitespace per Joe Perches. ]
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -5586,6 +5586,12 @@ sub process {
> > }
> > }
> >
> > +# check for smp_read_barrier_depends and read_barrier_depends
> > + if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {
> > + WARN("READ_BARRIER_DEPENDS",
> > + "Dependency barriers should only be used in READ_ONCE or DEC Alpha code" . $herecurr);
>
> Almost right. Missing a '\n' after "DEC Alpha code".
> Without the '\n', running checkpatch with --terse outputs badly.
>
> If you really wanted to optimize, you could make the first (smp_|)
> become (?:smp_|) to avoid the unused capture group.
> Or perhaps this could emit the actual type in the message like:
>
> if (!$file && $line =~ /\b((?:smp_|)read_barrier_depends)\s*\(/ {
> WARN("READ_BARRIER_DEPENDS",
> "$1 should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr);

How about like this? (s/$1/$1read_barrier_depends/).

Thanx, Paul

------------------------------------------------------------------------

commit e4f1d781e33c150547c68e55099794b98ee14d5e
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date: Mon Nov 27 09:37:35 2017 -0800

checkpatch: Add warnings for {smp_,}read_barrier_depends()

Now that both smp_read_barrier_depends() and read_barrier_depends()
are being de-emphasized, warn if any are added.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
[ paulmck: Skipped checking files and handled whitespace per Joe Perches. ]

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 95cda3ecc66b..9a384bfe2bd5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5586,6 +5586,12 @@ sub process {
}
}

+# check for smp_read_barrier_depends and read_barrier_depends
+ if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {
+ WARN("READ_BARRIER_DEPENDS",
+ "$1read_barrier_depends should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr);
+ }
+
# check of hardware specific defines
if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
CHK("ARCH_DEFINES",
\
 
 \ /
  Last update: 2017-12-04 20:07    [W:0.072 / U:1.612 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site