lkml.org 
[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][next] pinctrl: intel: ensure error return ret is initialized
On Mon, Dec 04, 2017 at 05:08:15PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the (unlikely) event that community->ngpps is zero, or if every
> gpp->gpio_base is less than zero, then an ininitialized value in
> ret is returned by function intel_gpio_add_pin_ranges. Fix this by
> ensuring ret is initialized to zero. It's a moot point, but I think
> it is worthwhile ensuring this corner case is fixed.

I agree.

> Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable")
>
> Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

\
 
 \ /
  Last update: 2017-12-04 18:30    [W:0.056 / U:0.476 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site